chore(mongodb-runner): add @mongodb-js namespace to the package name - #871
Open
gribnoysup wants to merge 4 commits into
Open
chore(mongodb-runner): add @mongodb-js namespace to the package name#871gribnoysup wants to merge 4 commits into
gribnoysup wants to merge 4 commits into
Conversation
1 similar comment
Anemy
approved these changes
Sep 2, 2026
nbbeeken
requested changes
Sep 2, 2026
nbbeeken
left a comment
Collaborator
There was a problem hiding this comment.
I assume code-points was unintentional (as it usually is), just leaving req changes so we don't miss that
What happens to the mongodb-runner package now? is there a way we can make one last release to it where it is just a re-export of this one?
Collaborator
Author
|
Yes, Anna asked me to adjust for that, although I think it's worth mentioning that as our main concern here is erroneous owners of the mongodb-runner package, re-exporting still leaves the potentially problematic dependency in the tree even if the version we know we published will be pointing to a new one. I'll push one small change related to that re-exporting shortly and will remove the accidentally committed file, thanks for spotting. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only way for us to deal with ownership issues with this package is to rename it to have the mongodb-js namespace