Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
alcaeus
force-pushed
the
fix-dangling-gridfs-stream
branch
from
September 16, 2026 05:47
47eed32 to
f9b1dc5
Compare
Contributor
Author
|
Test failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a rare issue with GridFS uploads. When uploading from a stream,
Bucket::uploadFromStreamrelies on the$destinationfile pointer to go out of scope and closed, which then triggers the write to the databases. However, Xdebug can end up holding an additional reference to this file pointer, which then causes the write to be skipped.To fix this, we wrap the entire write/return logic in a try-finally block to ensure the file pointer gets closed explicitly instead of relying on garbage collection to handle it for us.
Note: I haven't added a test for this as it is hard to reproduce. This appeared locally in my Doctrine ODM test suite as I run with Xdebug in
developmode by default. I confirmed locally that this patch fixes the failures I encountered.