Skip to content

Arguably, this library is too fragile #5

Description

@timhunt

Looking at the recent bug fixes, it seems that the way this library works, if anything goes wrong, it causes a fatal error, so you get no CSS at all.

A better strategy might be: Wrap the processing of each rule in a try-catch, and if there is an error, then just leave that rule alone (perhaps insert a CSS comment flagging the problem so it can be debugged - and Moodle coudl scan for those comments, and report them, before minifying the CSS).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions