Skip to content

Passing string as error to callback #8

Description

@161chihuahuas

If the dgram client errors, the callback receives an Error object, but if there is a timeout a String gets passed as the error callback which makes appropriate error handling a real pain:

https://github.com/moonpyk/node-ntp-client/blob/master/lib/ntp-client.js#L52

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions