Repository navigation
fix(git): stop Windows Git children after stdout overflow - #695
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestRunStdoutOverflowIsClassifiedDatafailed on the Windows agent runner during #694 (a TS-only PR): the test passed, thent.TempDircleanup could not remove the working directory.Cause: since #687,
git.runcancels as soon as stdout passes its cap. On Windows the Go process only kills the Git for Windows launcher (git.exewrapper); the real Git child it started keeps running for a moment and still holds the working directory as its cwd.Fix (Windows only):
git.runstarts Git suspended, assigns it to a job object before resuming it, and on stdout overflow terminates the job and waits (up to the existingWaitDelay) on the process handles captured before termination, so the tree is gone whenRunreturns.ResumeSuspendedmoves frominternal/chattointernal/processso chat and git share it;TerminateJobAndWaitand the job process-id list live there too.cmd.Run()unchanged.Tests: the existing overflow test now uses a fake launcher and child, and checks that the cwd can be removed right after
Run. No new test files.Checks
go vet ./...,GOOS={windows,linux,darwin} go build ./...,GOOS=windows go test -cfor git/process/chat,go test -count=1 ./...: pass locally.🤖 Generated with Claude Code