Skip to content

test(chat): give the Windows cmd-to-Node stdin test 30 s - #706

Merged
moreih29 merged 1 commit into
developfrom
fix/windows-stdin-test-deadline
Nov 19, 2026
Merged

moreih29 merged 1 commit into
developfrom
fix/windows-stdin-test-deadline

Conversation

@moreih29

Copy link
Copy Markdown
Owner

Summary

TestWindowsChatStdinReachesNodeThroughCmd (added in #690) failed once on the Release 0.35.0 PR (#705, run 44571313816 attempt 1) with stdin_windows_test.go:86: chat.send: context deadline exceeded. It had passed on #704 a few minutes earlier on the same code. The failed-job rerun passed, and locally it passes 10 of 10 runs in about 0.09 s each.

So the cause looks like the first cmd and node start on a fresh windows-latest runner, not the stdin path. This test's deadline goes from 10 s to 30 s. What it checks stays the same: stdin, including a 1 MiB line, reaches Node through a cmd batch launcher, followed by end of input. No other test's deadline changes.

Test plan

  • go test ./internal/chat -run TestWindowsChatStdinReachesNodeThroughCmd -count=3 on Windows: ok. Run it with NoDefaultCurrentDirectoryInExePath unset, since cmd otherwise does not find the .cmd in its folder.
  • CI

🤖 Generated with Claude Code

The whole run takes under a second, but on a fresh windows-latest runner the
first cmd and Node start once passed the 10 s deadline (chat.send: context
deadline exceeded), failing the release PR's agent tests. A rerun passed.
Only this test's deadline changes; what it checks stays the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@moreih29
moreih29 merged commit d7be2f5 into develop Nov 19, 2026
7 checks passed
@moreih29
moreih29 deleted the fix/windows-stdin-test-deadline branch November 19, 2026 17:10
@moreih29 moreih29 mentioned this pull request Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant