Repository navigation
test(chat): give the Windows cmd-to-Node stdin test 30 s - #706
Merged
Merged
Conversation
The whole run takes under a second, but on a fresh windows-latest runner the first cmd and Node start once passed the 10 s deadline (chat.send: context deadline exceeded), failing the release PR's agent tests. A rerun passed. Only this test's deadline changes; what it checks stays the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestWindowsChatStdinReachesNodeThroughCmd(added in #690) failed once on the Release 0.35.0 PR (#705, run 44571313816 attempt 1) withstdin_windows_test.go:86: chat.send: context deadline exceeded. It had passed on #704 a few minutes earlier on the same code. The failed-job rerun passed, and locally it passes 10 of 10 runs in about 0.09 s each.So the cause looks like the first
cmdandnodestart on a freshwindows-latestrunner, not the stdin path. This test's deadline goes from 10 s to 30 s. What it checks stays the same: stdin, including a 1 MiB line, reaches Node through acmdbatch launcher, followed by end of input. No other test's deadline changes.Test plan
go test ./internal/chat -run TestWindowsChatStdinReachesNodeThroughCmd -count=3on Windows: ok. Run it withNoDefaultCurrentDirectoryInExePathunset, since cmd otherwise does not find the.cmdin its folder.🤖 Generated with Claude Code