Repository navigation
fix(workspace): treat legacy rootPath createAndConnect as local - #708
Merged
Merged
Conversation
The IPC schema accepts the legacy { rootPath, name } shape, but the
handler only took the local branch when a location field was present,
so the legacy shape fell through to createAndConnectSsh and failed with
an internal error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace.createAndConnectaccepts the legacy{ rootPath, name }shape in its schema, but the handler only took the local branch whenlocationwas present. The legacy shape fell through tocreateAndConnectSsh, which threwcreateAndConnectSsh called for non-SSH locationand surfaced as an internal error.manager.createalready does.Found during Mac desktop QA for 0.35.0. No current renderer caller sends the legacy shape, so this is a hardening fix.
Test plan
bun run typecheckbun run lintbun test tests/unit/main/features/workspace tests/integration/ipc/round-trip.test.ts🤖 Generated with Claude Code