Repository navigation
feat!: check out the reviewed revision so language servers see it - #416
Draft
I-Al-Istannen wants to merge 3 commits into
Draft
I-Al-Istannen wants to merge 3 commits into
I-Al-Istannen wants to merge 3 commits into
Conversation
Language servers read the files on disk, so they only answered when the new side was the worktree or HEAD. Entering a review now checks out its new side when the worktree is clean: a local branch is switched to, any other commit (a pull request, a remote branch, a tag, a lone commit) is checked out detached. A dirty worktree, a refused switch, a range named after HEAD or with the worktree on either side leaves the checkout alone and says why. On exit diffle switches back unless HEAD moved since or the worktree is dirty. --no-checkout (and --no-lsp) turn it off.
A reload recomputed the review but left HEAD where it was, so after a push to the pull request or a fetch of the remote branch the new side moved past the checkout and the language servers went quiet. A recompute now checks out the new side again, as long as HEAD is still where this run left it.
A checkout rewrites files on disk that no open document covers. When a snapshot's HEAD differs from the last one, the files between the two commits go to every server as workspace/didChangeWatchedFiles. The capability stays unadvertised: rust-analyzer would otherwise stop watching files itself and expect every edit from diffle.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.