Repository navigation
[CM-244] Add additional fields for onboarding api ids plus rate - #20
Conversation
Request for data collection review formSummary: we are introducing an api to act as a "front door" for our ads platform. In order to do this we want
We will answer how many impressions and clicks an ad has had as well as the rate paid for these interactions.
So we can provide accurate reports and bills to our advertising partners.
We could continue using the ids that come from various ad providers but this is brittle and we plan to have all ads enter
Yes, but it is missing ids for the advertiser, account, campaign, and the rate paid for the interaction.
This collection is Glean so is documented in the Glean Dictionary.
This collection will be collected permanently. [todo someone's name]
This ping is not interested in users of firefox and is specific to the ads served. It should be totally devoid of any
This is default on, opt-out by turning off "sponsored shortcuts" and "sponsored stories" or flipping the "support firefox"
Aggregating clicks/impressions/price on campaign/creative/etc ids to generate reports and bills for advertisers.
This will not be shared.
This will go through server side glean via MARS (Mozilla Ad Routing Service), the same way it does today. Notably, this |
efixler
left a comment
There was a problem hiding this comment.
lgtm.
Can you remind me why we never use numeric types here?
I honestly don't know. I just stuck with it because that's how the rest of them are typed. The only thing that comes up for me is that we wouldn't have to change anything if we switch to uuids 🤷 |
A little extra context: the existing ones were all strings since the ids were externally managed so we have no control over whether they were ints or strings / and could vary by provider. If we're only storing ids we manage in these fields we could use whatever type we want. |
|
DATA COLLECTION REVIEW RESPONSE: Yes. No. It appears as though there is no way for a user to opt out of this data collection. No. The name of the individual was not specified. Category 2, Interaction. Default on. Yes. Unknown. No. Result: datareview- pending approval via Sensitive Data Collection Review This data contains identifiers and it appears as though there's no opt-out mechanism (though maybe I'm just unfamiliar with this service's mechanism). It should undergo Sensitive Data Collection Review (don't worry, it's not a big deal. Just an email thread with folks who can determine whether these collections are cool) to ensure 1) That it can correctly respect users' privacy through opt-out (if needed), and 2) That the identifiers being collected aren't going to link datasets we'd prefer to keep unlinked. Should that review complete successfully and an individual be named for the permanent collection of these data, this will become |
|
@chutten thank you for your review! I'll check out that link and get the process going. I wanted to clarify one thing
I think it might be worth calling out that user can opt-out of data collection by turning off ads entirely. Though, as far as I know, there is no way to have ads on but also have this collection disabled. |
|
Sensitive Data Collection review has completed successfully. This collection is okayed to proceed as specified. |
Currently pending sensitive data review
Ticket: https://mozilla-hub.atlassian.net/browse/CM-244
Bugzilla bug for review: https://bugzilla.mozilla.org/show_bug.cgi?id=2068778
In order to get telemetry for ads that come in via onboarding api we want to add a few new ids as well as the rate paid for the interaction. This represents the minimal data needed to generate a report or a bill for an advertiser that came in through the onboarding api.
This is the first time I've done a change to this so please let me know if I've missed a step!