Repository navigation
fix: treat DELETE collection w/ empty ids as an error - #2674
Merged
Merged
Conversation
pjenvey
changed the title
pjenvey
marked this pull request as ready for review
October 19, 2026 21:48
which uses #[serde(default)] so they're never passed the non-existent/None case (serde_urlencoded never produces it)
pjenvey
force-pushed
the
fix/delete-with-empty-ids-STOR-768
branch
from
October 19, 2026 22:16
5dd5729 to
da840e1
Compare
chenba
previously approved these changes
Oct 20, 2026
chenba
left a comment
chenba
left a comment
Collaborator
There was a problem hiding this comment.
Looks like we need to update a test? Otherwise 👍
chenba
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
and separately, simplify BsoQueryParam extractors
which uses #[serde(default)] so they're never passed the non-existent/None case (serde_urlencoded never produces it)
Issue(s)
Closes STOR-768