Repository navigation
File the bug even if the upstream commits can't be listed. Fixes #435 - #436
Merged
Merged
Conversation
Listing the upstream commits for a new bug's description means cloning the upstream repo. If that failed, the exception escaped _process_new_job after the job was created but before the bug was filed, leaving the job in CREATED with no bug. The next run cleaned it up as an unexpected state and marked it done, so the version was never reported. This happened to libvorbis when gitlab.xiph.org returned a 502. Catch the failure and file the bug anyway, with a description that says the commits couldn't be fetched and includes the error. Also add cache_clear() to @memoize functions so tests can make check_for_update run again.
There was a problem hiding this comment.
🟢 Approval recommended
The focused fallback preserves bug filing and job handling, with regression coverage and no unresolved findings.
No open issues 🎉
What changed in this PR
Keeps vendoring updates reportable when upstream commit retrieval fails, rather than leaving jobs without bugs.
Changes:
- File bugs with an explanatory fallback description when commit retrieval fails.
- Expose memoization cache clearing for tests.
- Add regression coverage for clone failures, including simultaneous vendoring failures.
| File | Description |
|---|---|
| tests/functionality_utilities.py | Allow simulated upstream clone failures. |
| tests/functionality_all_platforms.py | Test bug filing and job progression after failures. |
| tasktypes/vendoring.py | Continue bug filing without upstream commit details. |
| components/utilities.py | Expose cache_clear() on memoized functions. |
| components/bugzilla.py | Add the fallback bug-description template. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listing the upstream commits for a new bug's description means cloning the upstream repo. If that failed, the exception escaped _process_new_job after the job was created but before the bug was filed, leaving the job in CREATED with no bug. The next run cleaned it up as an unexpected state and marked it done, so the version was never reported. This happened to libvorbis when gitlab.xiph.org returned a 502.
Catch the failure and file the bug anyway, with a description that says the commits couldn't be fetched and includes the error. Also add cache_clear() to @memoize functions so tests can make check_for_update run again.