Conversation
Comments render markdown with cmark's safe option and every `<` escaped beforehand, so raw HTML never reaches the parser. Instead of weakening that, convert the four disclosure tags back to real elements after rendering: mark the escaped tags in text nodes (skipping pre/code so the syntax can still be documented), then re-parse so the block level elements are lifted out of the paragraph markdown wrapped them in. Only those four exact tags are recognized and they never carry attributes, so no other markup can be smuggled in. The marker characters are stripped from the input so they cannot be forged, and unbalanced tags cannot leak an unclosed element into the page.
* upstream/master: Bug 1995464 - Overhaul guided bug entry form Bumped version to 20260916.2 Revert "Bug 2061445 - Migrate Bugzilla (system info) REST resource to native Mojo API" Bumped version to 20260916.1 Bug 2072689 - Buglist link on My Dashboard is broken Bug 2069466 Bug 2060932 - Support GitHub-style collapsible sections in comments Bug 2072224 - Add REST auth precedence note to not-yet-migrated resources
* upstream/master: Bumped version to 20260922.1 Bug 2002553 - BMO rest api search: Failed to fetch key from network storage when an attachment has been deleted
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The corrected REST behavior lacks regression coverage for date custom fields.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates REST handling so date-only custom fields remain in YYYY-MM-DD format.
Changes:
- Converts only datetime custom fields during REST processing.
- Preserves date-only values for validation.
| File | Description |
|---|---|
Bugzilla/WebService/Bug.pm |
Separates date-only fields from datetime conversion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| next | ||
| unless ($field->type == FIELD_TYPE_DATETIME | ||
| || $field->type == FIELD_TYPE_DATE); | ||
| next unless $field->type == FIELD_TYPE_DATETIME; |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.