Repository navigation
feat(highwind): read metrics from metric-hub - #621
Open
jaredlockhart wants to merge 3 commits into
Open
jaredlockhart wants to merge 3 commits into
jaredlockhart wants to merge 3 commits into
Conversation
scholtzan
reviewed
Oct 27, 2026
mikewilli
reviewed
Oct 27, 2026
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class Metric: |
There was a problem hiding this comment.
Should this live in metric-config-parser as well?
Contributor
Author
There was a problem hiding this comment.
Oh I don't think so. The metric config surface is the minimal surface needed to store the information needed for the metric to be computable. Here this is really just a transformation from the defined format into how it'll be translated into the queries internally, so it doesn't introduce any information that's needed for the actual external facing metric definition. But good to probe 🙏
Because * Highwind's metrics and data sources are hard-coded, so they drift from the definitions Jetstream reads * Each experiment's resolved metric list is already computed in the Experimenter mirror This commit * Reads each experiment's metric names off the mirror's resolved Jetstream metric set and builds their SQL from metric-hub's nimbus/ definitions via metric-config-parser's aggregation_plan() * Resolves the analysis unit's source column per metric-hub data source instead of per app, and reads windows from the plan's cumulative_window/incremental_window/repeat_windows fields * Reports a metric that has no nimbus/ definition, or whose windows Highwind cannot express, against the experiments that asked for it, rather than computing it * Removes the hard-coded guardrail metrics, data sources and reducers, and installs git in the image so metric-config-parser can clone metric-hub at run time https://mozilla-hub.atlassian.net/browse/EXP-7631
Because * A metric-hub window that doesn't fit the bucket grid stopped the whole run * Every source was scanned for every unit with every experiment's metrics This commit * Reports metrics whose windows don't fit the 7-day bucket grid instead of failing the run * Builds each unit's queries from its own experiments' metrics and skips source and unit pairs with nothing to compute https://mozilla-hub.atlassian.net/browse/EXP-7631
jaredlockhart
force-pushed
the
exp-7631-highwind-metric-hub
branch
from
October 28, 2026 21:10
b801856 to
b61063b
Compare
Because * Calls through a module named metrics read like operations on a list of metrics * The discovery query grouped a list that is already one entry per metric This commit * Imports the metric-hub loading functions by name, with names that say what each does * Reads each experiment's metric list straight from the mirror without regrouping it * Rewords the run_windows docstring https://mozilla-hub.atlassian.net/browse/EXP-7631
scholtzan
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
https://mozilla-hub.atlassian.net/browse/EXP-7631
Checklist for reviewer:
Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
Scan the PR and verify that no changes (particularly to
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsEnsure the container image will be using permissions granted to telemetry-airflow responsibly.