Repository navigation
Duplicate function names in grcov reports - #1534
Open
bringhurst wants to merge 2 commits into
Open
bringhurst wants to merge 2 commits into
bringhurst wants to merge 2 commits into
Conversation
Name-only demangling maps C++ overloads to the same LCOV name. Reading the report back merges their coverage. Keep full signatures in FN and FNDA records. Add a round-trip test for parameter and const overloads, with and without demangling.
Use template methods to cover commas in template arguments. Export and read the report a second time to check that already-demangled names keep their coverage. Test both with and without demangling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grcovcan give two different C++ functions the same name in an LCOV report. The demangler drops the argument list, so overloads such asf(int)andf(int, int)both becomef:When another pass reads that report, it warns that
FN 'f'is duplicated and counts one function instead of two.So, this PR changes it to keep the full signature. The same example would then look like this: