Repository navigation
gcs: default external_account credential format to text in memory - #2889
Merged
Merged
Conversation
sylvestre
reviewed
Oct 9, 2026
sylvestre
reviewed
Oct 9, 2026
sylvestre
reviewed
Oct 9, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
+ Coverage 75.61% 78.57% +2.95%
==========================================
Files 74 74
Lines 43902 44114 +212
==========================================
+ Hits 33197 34662 +1465
+ Misses 10705 9452 -1253 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Addressed, PTAL. Thanks! |
sylvestre
reviewed
Oct 10, 2026
sylvestre
reviewed
Oct 10, 2026
sylvestre
force-pushed
the
fix/gcs-external-account
branch
from
October 24, 2026 09:55
f4540ad to
3a49bbf
Compare
Collaborator
|
Thanks for your PR |
akasakariko
added a commit
to akasakariko/akasakariko
that referenced
this pull request
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reqsign-google 3.1.0 cannot load external_account credentials when credential_source omits format, although AIP-4117 defaults it to text
For credentials referenced by SCCACHE_GCS_KEY_PATH or GOOGLE_APPLICATION_CREDENTIALS, sccache now inserts the default text format in memory before passing them to OpenDAL without rewriting the original file
Explicit formats remain untouched, empty environment paths are ignored, and an upstream fix is tracked in apache/reqsign#910
Fixes #2884