Conversation
Akemi
force-pushed
the
mac_open_file2
branch
from
September 13, 2026 19:16
4e513f3 to
7bf0a87
Compare
na-na-hi
approved these changes
Sep 18, 2026
drag and drop is enabled by default in the options, but disabled in the dnd handling in code before the initial property change event was dispatched. leading to ignored dropped-files events when dispatched too early. Fixes mpv-player#17921
this is a shortcoming of cocoa, so clarify this behavior till it can be fixed.
Akemi
force-pushed
the
mac_open_file2
branch
from
September 19, 2026 14:37
7bf0a87 to
6d274e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just to fix the file loading case on macOS for the time being and to restore the previous behavior. this doesn't cleanup the discrepancies between the different file open events on macOS yet, mentioned in the other PR.
hope this change is more acceptable for now and we can get rid of a blocker for a new release.
Alternative to #18225
Fixes #17921