Skip to content

DOCS/contribute.md: set expectations for issues, PR text and LLM use - #18502

Merged
kasper93 merged 1 commit into
mpv-player:masterfrom
kasper93:mll
Sep 22, 2026
Merged

kasper93 merged 1 commit into
mpv-player:masterfrom
kasper93:mll

Conversation

@kasper93

Copy link
Copy Markdown
Member

No description provided.

@CounterPillow

Copy link
Copy Markdown
Contributor

While the AGENTS.md is well-intentioned, I see a few problems:

  • It might come across as encouragement that these types of tools are part of the normal mpv development workflow
  • It mainly just repeats things already contained in DOCS/contribute.md. You'd think the omnipotent computer god can find the file every human contributor can find. If that's not the case, should we just make a symlink to DOCS/contribute.md? I recognise keeping the contents of AGENTS.md small is good for token usage or whatever but lol lmao
  • Fedinonhireds will see this file and go "MpV iS sLoP nOw!!1!1" and tell people to use mplayer (which, while funny, will leave gullible people with a shittier media player)

@kasper93

Copy link
Copy Markdown
Member Author

It might come across as encouragement that these types of tools are part of the normal mpv development workflow

It's unavoidable anyway at this point.

It mainly just repeats things already contained in DOCS/contribute.md. You'd think the omnipotent computer god can find the file every human contributor can find. If that's not the case, should we just make a symlink to DOCS/contribute.md? I recognise keeping the contents of AGENTS.md small is good for token usage or whatever but lol lmao

You would hope so, but I don't know. And I know that AGENTS.md is commonly baked into system prompts of those coding agents. Symlink seems like a good idea, but I worry it may backfire, if LLM takes the wording there as directed to AI, not human reader.

Fedinonhireds will see this file and go "MpV iS sLoP nOw!!1!1" and tell people to use mplayer (which, while funny, will leave gullible people with a shittier media player)

¯\(ツ)/¯

Drive-by contributions have become more and more problematic, so we
need to make the rules more explicit. At the same time, we don't want
to limit contributions, but make it clear that the submitter is supposed
to take responsibility for the change they are sending.

The biggest issue is overly verbose walls of text in issue or PR
descriptions for trivial code changes. What's worse, a big part of the
analysis is often simply wrong, making reviewers work twice as hard to
untangle the mess. Contributions are welcome, but we have to be mindful
of the time of everyone involved.

@sfan5 sfan5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but explicitly explaining common sense is not going to stop slop cultists

@kasper93

Copy link
Copy Markdown
Member Author

lgtm, but explicitly explaining common sense is not going to stop slop cultists

My main expectation is that LLM actually will read that, and adjust itself a bit.

@kasper93
kasper93 merged commit 6947452 into mpv-player:master Sep 22, 2026
8 of 16 checks passed
@kasper93
kasper93 deleted the mll branch September 22, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants