feat(therapy): drop card bytes as the commit parses them - #1
Merged
Merged
Conversation
An import was uploaded to be read once, but pap_file kept every byte of the card after the commit had written the parsed night, and nothing has read a byte back since: the panel, the export, the share and the admin read model all go through pap_day, pap_event and pap_channel. The opening slice now deletes every file left without a day, which covers the card level files it just parsed into the import, the ones whose night was replaced and the ones no date could be read from, and fillDay deletes a night's files in the transaction that stores the night. Transactional so a slice that rolls back keeps them and the client's retry still finds a night it can parse. A night that would not parse takes its files with it either way, through the dropped row's cascade or explicitly when the card's own summary is kept. The table stays: it is where a chunked upload lands and where the commit reads from. What it no longer is, is an archive, so a parser fix can only be replayed over a card uploaded again. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An import was uploaded to be read once, but pap_file kept every byte of the
card after the commit had written the parsed night, and nothing has read a
byte back since: the panel, the export, the share and the admin read model
all go through pap_day, pap_event and pap_channel.
The opening slice now deletes every file left without a day, which covers the
card level files it just parsed into the import, the ones whose night was
replaced and the ones no date could be read from, and fillDay deletes a
night's files in the transaction that stores the night. Transactional so a
slice that rolls back keeps them and the client's retry still finds a night it
can parse. A night that would not parse takes its files with it either way,
through the dropped row's cascade or explicitly when the card's own summary is
kept.
The table stays: it is where a chunked upload lands and where the commit reads
from. What it no longer is, is an archive, so a parser fix can only be replayed
over a card uploaded again.
Co-Authored-By: Claude noreply@anthropic.com