Repository navigation
Header: the mark from Mark.astro's small copies, one image per theme - #27
Merged
Merged
Conversation
- Sync from the website: Mark.astro holds one <picture> per mark. A <source> picks the dark GIF by the system theme, the <img> carries the light one, so only one downloads and the request leaves with the HTML, not after the stylesheet. The script swaps the source when a viewer has chosen a theme. - The docs header uses <Mark small>, the website's 96 px and 144 px copies (2x and 3x), in place of its own copy of the markup. The 144 px copies join the synced files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on mruspace/website#51. The tokens check (
sync-tokens.mjs --check) compares against the website'smain, so CI here fails until that PR merges. Locally, synced from the website branch,npm run checkpasses (e2e and Lighthouse included).Mark.astroholds one<picture>per mark. A<source>picks the dark GIF by the system theme, the<img>carries the light one, so only one downloads and the request leaves with the HTML, not after the stylesheet. The script swaps the source when a viewer has chosen a theme.<Mark small>, the website's 96 px and 144 px copies (2x and 3x), in place of its own copy of the markup. The 144 px copies join the synced files.Measured on the built docs site, system dark, 2x: only
mru-96.gifdownloads, and the footer toggle swaps tomru-light-96.gifwith the multiply blend.