Repository navigation
RedundancyManager: a cycle that closes late counts against no replica (MRU-RM-023, v0.6.0) - #36
Merged
Merged
Conversation
… (MRU-RM-023, v0.6.0) When the manager falls behind, the next cycle's tick waits in its queue in front of the replies, so each cycle closed before its answers were dispatched; three such cycles retired every replica as lost and halted. Seen once in CI (the deployment's restart test) and reproduced under CPU starvation. A cycle now closes late when other messages wait in the queue as it closes, or when every one of two or more expected answers is missing; then a missing answer counts against no replica, and a cycle with an answer missing is withheld. A late reply clears the replica's misses. New event CycleWithheld, telemetry Late, summary late=. Four unit tests; requirements MRU-RM-002, 009, 010, 014, 023 and D3.
…-answer retirement by one more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flaw. On one processor, when the manager's thread falls behind (a slow state-file write, a starved processor), the rate group's next tick waits in the manager's queue in front of the replies. Each cycle then closes before its answers are dispatched, and after three cycles every replica is retired as LOST and the run halts. CI hit it once in the restart test (PR #35, all three replicas retired). Under CPU starvation in a container (half a CPU, six busy loops, 20 ms cycles) it halted at cycle 4 on every try.
The rule (MRU-RM-023). A cycle closes late when other messages wait in the queue as it closes, or when every one of two or more expected answers is missing. In such a cycle a missing answer counts against no replica (no miss, no known-answer test or admission failed for a missing answer); a cycle with an answer missing is withheld (nothing delivered, no strike), counted in the new
Latetelemetry with a throttledCycleWithheldevent. A reply that arrives after its cycle closed clears the replica's misses. One replica left: silence counts as before.Evidence.
Also.
RunRecorderreadsLate; the summary reportslate=;scripts/fprime-deployment.shallows one count of slack per withheld cycle. Requirements D3, MRU-RM-002, 009, 010, 014 updated, MRU-RM-023 added. Version 0.6.0.