Keep json on 2.x for Ruby < 3.2 - #153
Merged
Merged
Conversation
Ruby 2.7 to 3.1 cannot use the locked activesupport 8.1, so bundler
re-resolves them to activesupport < 8.1, which still passes
`quirks_mode: true` to JSON.generate. json 3.0 (released 2026-09-07)
raises ArgumentError for unknown options, which broke the
`-r active_support/all` example test on those Rubies:
ArgumentError: unknown keyword: quirks_mode
json-3.0.2/lib/json/common.rb:382:in `generate'
activesupport-7.1.6/lib/active_support/json/encoding.rb:92:in `stringify'
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mtsmfm
force-pushed
the
fix-json-3-on-old-rubies
branch
from
September 16, 2026 02:34
4820a23 to
62a8836
Compare
mtsmfm
marked this pull request as ready for review
September 16, 2026 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 2.7 to 3.1 cannot use the locked activesupport 8.1, so bundler re-resolves them to activesupport < 8.1, which still passes
quirks_mode: trueto JSON.generate. json 3.0 (released 2026-09-07) raises ArgumentError for unknown options, which broke the-r active_support/allexample test on those Rubies: