Check dependent references - #158
Merged
Merged
Conversation
…pins Make the dependent test workflow install the released language_server-protocol gem and then overwrite its lib/ and sig/ with the local checkout. Dependents and their transitive dependencies from rubygems.org (standard -> rubocop, rubocop -> ruby-lsp) pin language_server-protocol to a released version range such as "~> 3.17.0", so bundler cannot resolve an unreleased version (e.g. a new 3.x.0.0) from a path source. The step verifies that the loaded VERSION matches the local checkout. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AR4y4vf6QWCk6mzN1dYmmf
The dependent test workflow only catches a removed or renamed constant when the dependent's test suite happens to exercise it. Add bin/check_references, which parses the dependent's Ruby sources with Prism, resolves aliases such as `LSP = LanguageServer::Protocol` and `Interface = LanguageServer::Protocol::Interface`, and fails when a referenced constant does not exist in the loaded gem. Constants the dependent defines itself (e.g. Steep::Interface::Substitution) are ignored. The script declares its Prism dependency with bundler/inline so it can run with plain `ruby` from a dependent's checkout; Prism ships with Ruby 3.3+, so no download happens on a current Ruby. Run it before the dependent's tests in the workflow. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AR4y4vf6QWCk6mzN1dYmmf
mtsmfm
force-pushed
the
check-dependent-references
branch
2 times, most recently
from
September 16, 2026 13:58
46ee5d1 to
d813784
Compare
mtsmfm
marked this pull request as ready for review
September 16, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.