Skip to content

Review-traced, unreproduced findings from the issue batch (settings race, keybinding save, idle text, last-checked time) #394

Closed as not planned

Description

@mubeda

Findings that code review traced during pull request 387 and that no test, lab run or Profiler record reproduced. They were not changed in that pull request. For the first three a fix was written and withdrawn, because a check of the fix found it would break behaviour that works today.

  1. Saved session defaults, two windows. Two windows that save providerSessionDefaults at the same instant can overwrite each other in one ordering. Withdrawn fix: a server-side cleanup under the settings lock; it could overwrite a model chosen in the same request, turn an invalid map into a valid one that drops other providers, and leave a retired default saved against an older server.
  2. Keybindings after a failed save. A failed keybinding save can leave the rejected binding visible to a new config subscriber. Withdrawn fix: committing the rules only after the file write; a disconnect between the rename and the commit could erase a saved binding.
  3. Text of an answer with no turn while a new message is being sent. A message sent while Claude streams an answer with no turn open can leave that answer's text marked streaming. Withdrawn fix: completing the text on the early result; it sent a context query to Claude during the new message's turn.
  4. Config stream, "last checked" after a resync. After a resync, a manual refresh that changes only timestamps can be suppressed while the held version advances, leaving the Settings "last checked" time stale. An attempted fix broke an existing test of the same stream.

Activity

  1. mubeda commented on Nov 19, 2026

    @mubeda
    OwnerAuthor

    Closing as not planned: none of the four was reproduced by a test or a run, and three attempted fixes introduced regressions that their own checks caught. Each needs a failing test first; reopen the specific item with one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions