[sumanjeet0012]

Fixes #43

Description

This pull request introduces fuzz testing for the py-multibase decoder. It implements the fuzz target using hypothesis to exercise the decode pipeline with random binary, string, and encoded permutations to ensure the package handles malformed input safely without crashing.

Changes

• Installed hypothesis as a development dependency in pyproject.toml.
• Added tests/test_fuzz.py containing:
  • test_decode_never_crashes
  • test_decode_string_never_crashes
  • test_roundtrip_never_crashes

[acul71]

Review (maintainer) — Request changes

Thanks for adding Hypothesis fuzz coverage for decode() — this aligns well with #43 and CI is green.

Blocker

Missing newsfragment for issue #43. Please add something like:

newsfragments/43.misc.rst

Added Hypothesis-based fuzz tests for ``decode()`` robustness.

(File must end with a newline.) Type misc or internal is appropriate for a test-only change.

Also recommended

1. Rebase onto current origin/master (branch is ~6 commits behind; dry-run merge had no conflicts, but pyproject.toml overlaps with open #49 and #56).
2. In test_roundtrip_never_crashes, when both encode and decode succeed, assert decoded == data so silent corruption cannot pass.
3. Consider seeding Hypothesis with multibase spec vectors (closer to go-multibase FuzzDecode / the #43 proposal).

Validation (local)

• make lint — pass
• make typecheck — pass
• make test — 269 passed
• make docs-ci — pass

Full write-up: maintained locally as AI-PR-REVIEW-57-0.md.

[acul71]

Hi @sumanjeet0012 — friendly follow-up.

I requested changes on this PR on 2026-09-07 (mainly the missing towncrier newsfragment, plus the other notes in that review). I don’t see any new commits addressing those items yet.

Are you still willing / able to carry this PR forward? If yes, please push the requested updates when you can and I’ll re-review promptly. If your bandwidth has changed, no worries — just say so and we can close it or leave it for someone else to pick up.

[acul71]

Re-review — newsfragment OK; one recommended fix + sync

Thanks for adding newsfragments/43.internal.rst — the prior mandatory blocker is resolved.

Still please address

1. Sync with master — remote tip is 10 behind / 3 ahead. Local merge into a worktree was clean; maintainerCanModify is false so please rebase/merge yourself (and consider enabling maintainer edits).
2. In test_roundtrip_never_crashes, when encode+decode both succeed, please assert decoded == data so silent corruption cannot pass:

   encoded = encode(enc.encoding, data)
   decoded = decode(encoded)
   assert decoded == data

Optional (non-blocking): seed Hypothesis with multibase spec vectors.

Validation (worktree after merging master)

• Local: make lint, typecheck, test (361 passed, 9 skipped), docs-ci — green.
• GitHub CI on tip: green.

Happy to approve once the roundtrip assert is in and the branch is synced.