xml to toml transition - #637
Merged
Merged
Conversation
Resolve the bin/conpot modify/delete conflict by keeping the cli.py entrypoint from main and porting the TOML template loading into the refactored startup path. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Make TFTP TOML-only, use explicit databus value/function encoding, restore STIX ports from protocol templates, and document the dual-format contract with tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Sep 14, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces TOML as a first-class template format (dual-format with XML fallback), with TFTP as the reference migration. Closes the gap between the early
xml_to_tomlscaffolding and a mergeable slice of #534.template.toml/<protocol>.tomlwhen present; fall back to XML + XSD otherwise.template.toml; TFTP is TOML-only (tftp.xmlremoved).{ value = "..." }(eval),{ function = "module.Class" [, params = [...]] }.AGENTS.mddescribe the dual-format contract;schemavalidates TOML at startup.Non-goals for this PR: migrating bacnet/modbus/http/etc., proxy TOML, removing XML/XSD, or closing #534.
Test plan
uv run pytest conpot/tests/test_toml_templates.py conpot/tests/test_templates.py conpot/tests/test_protocol_startup.pyuv run conpot --template default -fstarts with TOML base + TFTP dict path; other protocols still load XMLFollow-ups
Remaining protocol/profile migrations: #638 (under #534).