Repository navigation
Improve ROM config option validation for RTC and REGIONFREE boolean - #3
Open
networkfusion wants to merge 1 commit into
Open
networkfusion wants to merge 1 commit into
networkfusion wants to merge 1 commit into
Conversation
ROM authors that use ROM config options may add "N64_ROM_RTC = 0" to their makefiles and expect it to disable the RTC, but in actual fact this will include it. This adds the `filter-out` command so that it works as expected. The same fix was performed for N64_ROM_REGIONFREE.
networkfusion
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROM authors that use ROM config options may add "N64_ROM_RTC = 0" to their makefiles and expect it to disable the RTC, but in actual fact this will include it. This adds the
filter-outcommand so that it works as expected.The same fix was performed for N64_ROM_REGIONFREE.
This is a clone of the PR from DragonMinded/libdragon#1004