Skip to content

[ENH] ASR: build clean_windows sample mask without quadratic concat #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sappelhoff merged 2 commits into from
Jul 10, 2026
Merged

[ENH] ASR: build clean_windows sample mask without quadratic concat #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e82b383
perf(asr): build clean_windows sample mask without quadratic concat
sappelhoff Jul 2, 2026
7b88a08
Merge branch 'master' into perf/asr-cleanwindows-boolmask
sappelhoff Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions meegkit/asr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,23 +367,13 @@ def clean_windows(X, sfreq, max_bad_chans=0.2, zthresholds=[-3.5, 5],
removed_wins = np.where(remove_mask)[0]

# reconstruct the samples to remove
sample_maskidx = []
for i, win in enumerate(removed_wins):
if i == 0:
sample_maskidx = np.arange(offsets[win], offsets[win] + N)
else:
sample_maskidx = np.r_[(sample_maskidx,
np.arange(offsets[win], offsets[win] + N))]
remove = np.zeros(ns, dtype=bool)
for win in removed_wins:
remove[offsets[win]:offsets[win] + N] = True

# delete the bad chunks from the data
sample_mask2remove = np.unique(sample_maskidx)
if sample_mask2remove.size:
clean = np.delete(X, sample_mask2remove, axis=1)
sample_mask = np.ones((1, ns), dtype=bool)
sample_mask[0, sample_mask2remove] = False
else:
clean = X
sample_mask = np.ones((1, ns), dtype=bool)
sample_mask = ~remove[None, :]
clean = X[:, ~remove] if remove.any() else X

if show:
import matplotlib.pyplot as plt
Expand Down
Loading