Repository navigation
Accept None ConfigStore nodes and skip hydra-core bridge in plugin scan - #87
Merged
Merged
Conversation
hydra-core accepts node=None, and lerna's hydra-core bridge plugin relies on it. With omegaconf 2.4, OmegaConf.structured(None) returns None rather than a None-valued DictConfig, so passing it to to_container raised ValueError. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
hydra_plugins.lerna exists so hydra-core can find plugins registered for lerna. Lerna reads those entry points itself, and importing the bridge without hydra-core installed printed an import error on every plugin scan. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Contributor
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two gaps found while running lerna without hydra-core (nbprint in Pyodide, and ccflow with Point72/ccflow#182):
ConfigStore.store(node=None)raisedValueError: Input cfg is not an OmegaConf config objecton omegaconf 2.4, whereOmegaConf.structured(None)returnsNoneinstead of a None-valuedDictConfig. hydra-core acceptsnode=None, and lerna's own hydra-core bridge plugin calls it that way.hydra_plugins.lerna, the bridge that lets hydra-core find plugins registered for lerna. Lerna reads those entry points itself, and without hydra-core installed every scan printedError importing 'hydra_plugins.lerna'. The scanner now skips it.Both new tests pass on omegaconf 2.3 with hydra-core and on omegaconf 2.4 without it, and each fails with its fix reverted. The rest of the suite matches main locally.
Type of Change
Checklist
make lint)make test)