Repository navigation
test: the zipfile check is skipped, said so, where sqlite3 has no zipfile - #8
Merged
Merged
Conversation
…file macOS 15's sqlite3, on GitHub's runners, cannot build the sample and so cannot read through it either. Any other failure to build it still fails the check. Closes #7 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GitHub's `macos-15` runners `/usr/bin/sqlite3` has no `zipfile` module, so the sample for "a virtual table in the schema reads nothing of another file" cannot be built, and `test` has failed on every run since the move to hosted runners, `main` included. A sqlite3 without the module cannot read through it either, so there is nothing to guard there.
The check now prints `skip … (this sqlite3 has no zipfile)` only when building the sample fails with `no such module: zipfile`. Any other failure to build it fails the check, which is stricter than before. On a Mac whose sqlite3 has `zipfile` the check runs as it did: `sh test/test.sh` → `ok sqlite: a virtual table in the schema reads nothing of another file`, `all passed`.
Closes #7
🤖 Generated with Claude Code