Skip to content

fix: propagate Mach-O signing failures - #3

Merged
takeokunn merged 2 commits into
mainfrom
codex/prod-errors
Oct 7, 2026
Merged

takeokunn merged 2 commits into
mainfrom
codex/prod-errors

Conversation

@takeokunn

Copy link
Copy Markdown
Contributor

Summary

  • make missing, timed-out, and failed Mach-O codesigning fail the writer
  • retain structured success diagnostics
  • add failure-injection coverage for the public writer boundary

Verification

  • git diff --check passed locally
  • targeted test command is blocked locally because ASDF cannot find cl-log-kit; CI must verify the selected failure-injection test

The change is based on the latest origin/main.

@takeokunn

Copy link
Copy Markdown
Contributor Author

Independent review findings and resolution:

  • The review identified that signing failure could leave an unsigned target behind. Fixed in 0c2a62d by signing a same-directory staged file and atomically replacing the target only after success; failures now signal exported macho-codesign-error.
  • The review identified that the original injection test depended on the host /usr/bin/codesign. Replaced it with deterministic injection of both process failure and timeout callbacks, including an assertion that the existing target remains unchanged.
  • Updated the API and concepts documentation to describe the propagated failure contract.

CI verification: run 37572516996 passed. The two failure-injection tests were selected and passed; the suite reported 202 passed, 2 skipped, 0 failed, 0 errored, 204 total.

@takeokunn
takeokunn merged commit 08ba383 into main Oct 7, 2026
1 check passed
@takeokunn
takeokunn deleted the codex/prod-errors branch October 7, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant