You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor: establish shared foundation for v0.6.0 - #24
Independent review found blocking gaps; do not merge yet.\n\n1. PTY coverage is skipped in CI: t/helpers-runner.lisp:60-70 makes skip-when-pty-round-trip-unreliable skip whenever CI is set, and t/integration/test-pty.lisp:386-406 places the important pty-open-write-read-close round-trip behind that macro. The observed CI result is 2329 selected, 2328 passed, 1 skipped, so a PTY regression can pass all required jobs. Please provide a deterministic CI PTY verification path (or an equivalent explicitly gated job) and make the gate fail when the required PTY check is unavailable.\n\n2. Timeout predicate mutation survives: src/infrastructure/acl/timeout.lisp:9-13 is covered only by truthy default checks at t/unit/test-execute-pipeline.lisp:443-447 and 606-610. Replacing timeout-seconds-p with a constant true result leaves the suite green; negative/non-numeric/non-finite inputs are not asserted. Add boundary contract tests and reject non-finite values if the predicate promises finite timeouts.\n\n3. The launch acceptance condition requires removing macOS/ARM system evaluation, but flake.nix:176-179 still declares aarch64-darwin. CI has no macOS job, but the flake still evaluates that platform. Remove it or explain and update the acceptance condition before merge.\n\nCI evidence: all four Ubuntu x86_64 checks pass, but the skipped PTY test means this is not sufficient evidence for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
nix flake show --all-systems --no-write-lock-file(exit 0)sbclASDF load ofnshell.asd(exit 0)paredit inspect checkon all changed Lisp/ASD files (exit 0, 9 files)Scope
Wave 0 only: baseline, dependency pins, ASDF modules, and shared CPS/test/timeout foundation. No merge or release performed.