Use Windows typography and fix control layout - #453
Conversation
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thermo-nuclear code quality review: CHANGESP2: this adds another feature-specific block to a 6k-line global stylesheet
Keep the font token/global control primitive here, but move Settings/account layout into a focused Settings stylesheet or owning component styles, and collapse the duplicate select declarations. The current direction makes an already giant shared file harder to reason about for unrelated UI work. |
Summary
Shared Windows surfaces and the floating bar now prefer Segoe UI Variable. Native selects reserve space for a bounded arrow in both themes, and Settings fields and account action rows use consistent sizing and containment.
Usage metrics, charts, pace visibility, and provider-card ordering are unchanged in this PR. The existing select interaction test is updated for the simplified control markup.
Based independently on upstream main at
029a5e3d; no other PR in this series is required.Validation
scripts/local-check.ps1 -Slice cion9ae96d73: workspace formatting, Clippy with-D warnings, Rust tests, frozen pnpm install, frontend tests/build, and interaction-guard script tests.RUST_TEST_THREADS=4; no tests were filtered out (the existing opt-in compatibility test remains ignored where present).pnpm --dir apps/desktop-tauri run tauri:build:debugfor this exact branch.git diff --check.UI / tray proof
CUA Driver checks were performed against the freshly rebuilt executable for this branch. Verified General settings in Auto/dark and Light: readable Windows typography and bounded select arrows. Restored Auto, enabled the floating bar, confirmed its native window and rendered provider pills while Settings stayed dark, then restored the floating bar to off. Scrolled Codex account controls and verified complete Refresh usage, Switch, Remove, and Add account labels within the panel.
Local proof:
.local/upstream-split/proof5/general-current.png,.local/upstream-split/proof5/general-key.png,.local/upstream-split/proof5/menu-float-enabled.png,.local/upstream-split/proof5/float.png,.local/upstream-split/proof5/account-actions.png. Account screenshots remain local because they contain private identities; this note records the observed behavior.