Skip to content

Fix dark theme select popups - #472

Open
Finesssee wants to merge 1 commit into
mainfrom
fix/issue-470-dark-select
Open

Fix dark theme select popups#472
Finesssee wants to merge 1 commit into
mainfrom
fix/issue-470-dark-select

Conversation

@Finesssee

@Finesssee Finesssee commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • stop forcing the shared native select control into the light color scheme
  • apply explicit dark native select/option colors under the dark theme
  • preserve the existing light popup behavior with an explicit light color scheme

Fixes #470

Validation

  • reproduced on the exact shipped v0.56.8 Windows build with CUA: the dark Settings surface opened the native select popup with a white background and low-contrast option text
  • pnpm --dir apps/desktop-tauri test: 59 files, 343 tests passed
  • pnpm --dir apps/desktop-tauri run build: passed, including locale drift check and TypeScript build
  • git diff --check: passed
  • fresh pnpm --dir apps/desktop-tauri run tauri:build:debug was attempted for post-fix CUA proof. The frontend build completes, but Rust dependency build scripts fail because this machine resolves link.exe to C:\Program Files\Git\usr\bin\link.exe instead of the MSVC linker. A fresh desktop binary could therefore not be produced locally for post-fix CUA capture.

UI proof note

The pre-fix native WebView2 popup was captured on Windows. The fix is limited to the theme-specific CSS controlling that same native select. Hosted Windows CI should provide the fresh build gate; post-fix native-popup CUA is the only local check blocked by the machine linker configuration.

Summary by CodeRabbit

  • Style
    • Improved dark-theme select controls with darker option backgrounds and clearer selected-option styling.
    • Preserved light-theme appearance for select controls.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e119143d-4708-457c-ac96-618708077d58

📥 Commits

Reviewing files that changed from the base of the PR and between f650147 and 3e8b873.

📒 Files selected for processing (1)
  • apps/desktop-tauri/src/styles.css

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

Select controls now use explicit theme-specific color schemes. Dark-theme options use dark backgrounds, and selected options use the accent color with white text. Light-theme controls retain a light color scheme.

Changes

Select theme styling

Layer / File(s) Summary
Theme-specific select rules
apps/desktop-tauri/src/styles.css
Dark-theme selects now style options with dark colors and accent-colored checked options. Light-theme selects explicitly use a light color scheme.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 3e8b8

Native select popups now use theme-appropriate colors in dark and light modes, restoring readable dark-theme options without changing application behavior beyond select styling.

Suggested reviewers: xuelongmu, blazzzplay

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing dark-theme select popups.
Linked Issues check ✅ Passed The changes address issue #470 by applying dark styling to native select popups and options while preserving explicit light-theme behavior.
Out of Scope Changes check ✅ Passed The changes are limited to select popup color-scheme and option styling in styles.css. They are directly related to issue #470 and the stated PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-470-dark-select

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Dropdown options are unreadable in dark theme

1 participant