Repository navigation
feat: ask for a review after a success, not at launch - #35
Merged
Merged
Conversation
noeGnh
approved these changes
Oct 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review prompt showed at launch, after 10 launches over 10 days. It now shows right after a code worked:
AppLifecycleListenerin thereviewPromptprovider). A reply continued in the dialer waits for the return too.As before, it is asked once in the app's life (
reviewRequested), never after every code, and Play limits how often the sheet actually appears. Only for someone who uses the app: 5 launches, at least 3 days after the first. If the flow can't run, the next code that works tries again. The privacy policy stays accurate (first launch date and launch count, used to pick the moment).Tests:
test/services/review_prompt_test.dartrewritten (launch never asks, both moments, the dialer case, the thresholds, once only, retry). On the emulator, dialing a code doesn't ask while the dialer is in front, and coming back to the app reaches Play Core'srequestInAppReview. The emulator has no Play Store, so the sheet itself can't show, and the in-app reply needs a real SIM.