Repository navigation
Preserve recording files and expose typed acquisition metadata - #5
Closed
han-xudong wants to merge 10 commits into
Closed
han-xudong wants to merge 10 commits into
han-xudong wants to merge 10 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording risks overwriting a competing destination and can report success without usable samples. Keep an exclusive handle, promote output without replacement, retain partial files on failure, and return bounded no-data/fault outcomes. Add shared acquisition summaries and a typed command inventory with clean source identity.
Pin the SDK candidate from netft/netft-cpp#21 while preserving the checksum-verified bias/socket adapter. Fix deadline saturation and clang-tidy findings, and replay adaptation bytes independently of Windows autocrlf.
Validation: five native platforms passed run 37609013125; after adding the snapshot guard, four platforms passed run 37610041333. Windows snapshot verification and 30 native suites passed there, with one adaptation-tool failure fixed here. Final focused Windows run 37611614857 passed snapshot verification, all 31 native/tool suites and the PowerShell installer checks. Local affected native/process/tool tests passed; no release is published.
Superseded by #6 after the source branch was renamed to
fix/ecosystem-improvements. The implementation commit is unchanged; this closed PR retains the original discussion and acceptance history.