Skip to content

Harden ROS conversion, executor health and enforced bias permissions - #22

Closed
han-xudong wants to merge 5 commits into
mainfrom
codex/ecosystem-improvements
Closed

han-xudong wants to merge 5 commits into
mainfrom
codex/ecosystem-improvements

Conversation

@han-xudong

@han-xudong han-xudong commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Reject nonfinite/overflowing SI conversion and make auxiliary executor failures visible. Add allow_bias control, wall-clock diagnostics, and concrete lifecycle/time/support guidance. Pin the checked SDK candidate from netft/netft-cpp#21.

Provide usable SROS2 driver/reader/operator profiles and a bounded Enforce integration check: reader receives samples but cannot send bias, while operator sends exactly one bias to a loopback fake sensor. Profiles include required rosout, parameter_events and own parameter reply permissions.

Validation: final CI 37610033066 passed Noetic, Humble, Jazzy, Kilted, Lyrical and Rolling node/control tests. Jazzy CI and local Kilted passed the real SROS2 allow/deny checks and isolated controller fault tests. No real sensor configuration was changed; no release is published.

Superseded by #23 after the source branch was renamed to fix/ecosystem-improvements. The implementation commit is unchanged; this closed PR retains the original discussion and acceptance history.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ci Continuous integration and repository automation driver Driver implementation and runtime behavior ros2-control ros2_control integration tests Test coverage and test infrastructure dependencies Dependency updates labels Oct 7, 2026
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration and repository automation dependencies Dependency updates documentation Improvements or additions to documentation driver Driver implementation and runtime behavior ros2-control ros2_control integration tests Test coverage and test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant