Repository navigation
Harden ROS conversion, executor health and enforced bias permissions - #22
Closed
han-xudong wants to merge 5 commits into
Closed
han-xudong wants to merge 5 commits into
han-xudong wants to merge 5 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject nonfinite/overflowing SI conversion and make auxiliary executor failures visible. Add allow_bias control, wall-clock diagnostics, and concrete lifecycle/time/support guidance. Pin the checked SDK candidate from netft/netft-cpp#21.
Provide usable SROS2 driver/reader/operator profiles and a bounded Enforce integration check: reader receives samples but cannot send bias, while operator sends exactly one bias to a loopback fake sensor. Profiles include required rosout, parameter_events and own parameter reply permissions.
Validation: final CI 37610033066 passed Noetic, Humble, Jazzy, Kilted, Lyrical and Rolling node/control tests. Jazzy CI and local Kilted passed the real SROS2 allow/deny checks and isolated controller fault tests. No real sensor configuration was changed; no release is published.
Superseded by #23 after the source branch was renamed to
fix/ecosystem-improvements. The implementation commit is unchanged; this closed PR retains the original discussion and acceptance history.