Skip to content

[NAE-2477] Builder translations - #355

Merged
Retoocs merged 5 commits into
release/6.6.0from
NAE-2477
Sep 28, 2026
Merged

Retoocs merged 5 commits into
release/6.6.0from
NAE-2477

Conversation

@Retoocs

@Retoocs Retoocs commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

Quick fixes after testing

Fixes NAE-2477

Summary by CodeRabbit

  • New Features
    • Added action-editor labels for process references and string collections in English, German, and Slovak.
  • Bug Fixes
    • Corrected the Mini FAB label in the field list.
    • Fixed an error that could prevent XML imports from saving their history entry.

- fix string concatenation in model-import-service.ts
@Retoocs Retoocs self-assigned this Sep 22, 2026
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d3a33188-0402-492e-b54a-d360dae82904

📥 Commits

Reviewing files that changed from the base of the PR and between 4bbdf43 and f1b8617.

📒 Files selected for processing (7)
  • projects/netgrif-components-core/src/assets/i18n/de.json
  • projects/netgrif-components-core/src/assets/i18n/en.json
  • projects/netgrif-components-core/src/assets/i18n/sk.json
  • projects/netgrif-components/src/lib/builder/form-builder/field-list/field-list.service.ts
  • projects/netgrif-components/src/lib/builder/modeler/actions-mode/action-editor/action-editor/action-editor.component.ts
  • projects/netgrif-components/src/lib/builder/modeler/data-mode/data-detail/data-detail.component.ts
  • projects/netgrif-components/src/lib/builder/modeler/model-import-service.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The changes add two data types to the action-editor menu and its translations, update the mini-fab title translation key, use a data-type enum constant, and fix string concatenation in model-import history.

Changes

Action-editor type options

Layer / File(s) Summary
Add action-editor type options
projects/netgrif-components-core/src/assets/i18n/{de,en,sk}.json, projects/netgrif-components/src/lib/builder/modeler/actions-mode/action-editor/action-editor/action-editor.component.ts, projects/netgrif-components/src/lib/builder/modeler/data-mode/data-detail/data-detail.component.ts
The English, German, and Slovak translations add processRef and stringCollection labels. The action-editor menu adds both types, and the data-detail type list uses DataType.STRING_COLLECTION.

Mini-fab translation key

Layer / File(s) Summary
Update mini-fab translation key
projects/netgrif-components/src/lib/builder/form-builder/field-list/field-list.service.ts
The mini-fab title key changes from MiniFAB to miniFab. The component name remains minifab.

Model-import history string

Layer / File(s) Summary
Fix history string concatenation
projects/netgrif-components/src/lib/builder/modeler/model-import-service.ts
The historyService.save string concatenates the translated model label and the model ID.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to f1b86

The editor retains the new selections locally, while acceptance by the XML exporter remains unverified; no concrete failure is established. The other summarized changes add labels, use a type constant, and repair history-string concatenation, with no identified merge blocker.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: updates to builder translations. It also remains consistent with the added action-editor type labels and the related builder fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Retoocs
Retoocs marked this pull request as ready for review September 24, 2026 11:20
@sonarqubecloud

Copy link
Copy Markdown

@Retoocs
Retoocs merged commit d87dbd8 into release/6.6.0 Sep 28, 2026
11 checks passed
@Retoocs
Retoocs deleted the NAE-2477 branch September 28, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants