Conversation
Accept both missing-server responses during cleanup so first-time registrations can continue. Return other errors safely when they have no wrapped cause. Assisted-by: Codex:GPT-6-Astra
Fanvil refuses to delete a server while its phone is registered. Deregister the phone before replacing its server to prevent the subsequent creation from failing because the name already exists. Check the deregistration response and allow an absent device. Assisted-by: Codex:GPT-6-Astra
Amygos
marked this pull request as ready for review
September 14, 2026 10:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e409e0a9ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Amygos
added a commit
that referenced
this pull request
Sep 14, 2026
Snapshot managed settings and registration before replacing a Fanvil group. Read back uncertain mutations and make one verified recovery pass so failed updates restore the original registered or unregistered state. Serialize updates per phone and return success for completed or identical requests. Use structured XML/JSON decoding with Fanvil's response charsets and a 30-second timeout. Keep recovery details free of configuration values. Verified with local failure injection and race tests, go vet, go build, and live test-phone recovery plus the supplied Fanvil script case. Review: #76 (comment) Assisted-by: Codex:GPT-6-Astra
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Amygos
force-pushed
the
fix/fanvil-registration
branch
from
September 14, 2026 11:44
61c0f23 to
e409e0a
Compare
Amygos
added a commit
that referenced
this pull request
Sep 14, 2026
Snapshot managed settings and registration before replacing a Fanvil group. Read back uncertain mutations and make one verified recovery pass so failed updates restore the original registered or unregistered state. Serialize updates per phone and return success for completed or identical requests. Use structured XML and JSON decoding with a 30-second timeout. Keep recovery details free of configuration values and preserve the existing Fanvil XML-RPC credential transform. Review: #76 (comment) Assisted-by: Codex:GPT-5.6-Sol
Amygos
added a commit
that referenced
this pull request
Sep 14, 2026
Validate the replacement URL before deregistering the phone. Serialize updates for the same MAC and bound every Fanvil request with a timeout. Missing devices and groups remain valid cleanup states, so clients can repeat the request after a partial or transient failure. The phone can remain unregistered until a retry succeeds. Review: #76 (comment) Assisted-by: Codex:GPT-5.6-Sol
Amygos
force-pushed
the
fix/fanvil-registration
branch
from
September 14, 2026 12:21
61d1d05 to
c9a12da
Compare
Validate the replacement URL before deregistering the phone. Serialize updates for the same MAC and bound every Fanvil request with a timeout. Missing devices and groups remain valid cleanup states, so clients can repeat the request after a partial or transient failure. The phone can remain unregistered until a retry succeeds. Review: #76 (comment) Assisted-by: Codex:GPT-5.6-Sol
Amygos
force-pushed
the
fix/fanvil-registration
branch
from
September 14, 2026 12:24
c9a12da to
4089d16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-registering an existing Fanvil phone fails with
Error:server_not_existedbecause its server is deleted before the phone is deregistered. The provisioning URL cannot be updated while the server remains in use.Deregister the phone before replacing its MAC-named server and registering it again. Check the deregistration response while allowing an absent device, accept both missing-server error spellings during deletion, and return errors safely when they have no wrapped cause.
Validate the replacement URL before changing the remote state, serialize updates for the same MAC, and use a bounded HTTP timeout. If a provider error interrupts the replacement, Falconieri returns its existing HTTP 500 error response. The client can repeat the same
PUT: cleanup accepts an already absent phone or server, so the request can resume from any partial state. The phone can remain unregistered until a retry succeeds.The flow continues to use one server per phone, named after its MAC address.
How to test
go buildand start Falconieri with a configured Fanvil account.PUT /providers/fanvil/<MAC>with a provisioning URL for a test phone, then repeat the request with an updated URL. Both requests should return HTTP 200.Validation performed:
go vet ./...andgo build ./...pass.