Repository navigation
Share the ranking skeleton of the three SCIP maps; pin their output (cleanup S5) - #233
Merged
Merged
Conversation
ImpactMap::query and ImplementsMap::query repeated the same skeleton: per-seed edges, the drop count, the global cap, dedupe by destination, truncation to the request limit, the Partial note, the cost, and the hit and evidence construction. One function next to cap_edges in edge.rs, ranked_hits, now holds it; each map passes its descriptor, cap, note noun, edge source and evidence detail. The agent-facing note and detail strings are passed in verbatim. Evidence: cargo test -p lci-maps --lib scip_ 65 passed, 1 ignored, before and after; traverse_matrix 18/18 (goldens byte-identical); clippy --workspace --all-targets -D warnings clean; fmt clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TestedByMap::query was a third copy of the ranking skeleton (cap EXPAND_LIMIT, noun "test units", detail "tests the seed at"). It now calls the shared function, renamed scip_ranked_hits since all three callers are SCIP maps; its doc says the cap is only reported. New pins per map, written and green before the move: the full Partial note, rank, score and the first evidence (via, edge, label, detail), plus a two-seed query that pins which edge survives the dedupe of a shared destination and that limit 1 truncates to the first hit. Evidence: cargo test -p lci-maps --lib 571 passed, 3 ignored, before and after the move; traverse_matrix 18/18; clippy --workspace --all-targets -D warnings clean; fmt clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The winning seed is now listed second, so the dedupe tests fail if the global re-sort by site goes; the limit-10 hit order and the limit-1 hit are literals instead of self-comparisons. Evidence: cargo test -p lci-maps --lib 571 passed, 3 ignored; fmt and clippy -p lci-maps --all-targets -D warnings clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup S5 pick 2, behaviour-preserving.
ImpactMap,ImplementsMapandTestedByMaprepeated the samequeryskeleton: per-seed edges, the drop count, the global sort, dedupe by destination, truncation to the limit, the Partial note, the cost, and hit and evidence construction. One function inlci-maps/src/edge.rs,scip_ranked_hits, now holds it. Each map passes its descriptor, cap, note noun, edge source and evidence detail, and the agent-facing note and detail strings are passed in verbatim.Not changed here, for a later output-change slice: the Partial note quotes the configured cap while the applied cap is
min(cap, 256).Evidence:
cargo test -p lci-maps --lib571 passed, 3 ignored;traverse_matrix18/18 (goldens untouched),recipes::6/6,run_records::5/5 (map-equivalence),navigation::144/144; clippy--workspace --all-targets -D warningsand fmt clean. Two review passes checked byte-identity against the old bodies.🤖 Generated with Claude Code