Skip to content

Share live editor content for unsaved notes - #3303

Open
xhon-pelushi wants to merge 1 commit into
nextcloud:mainfrom
xhon-pelushi:fix/share-unsaved-note-content-3300
Open

Share live editor content for unsaved notes#3303
xhon-pelushi wants to merge 1 commit into
nextcloud:mainfrom
xhon-pelushi:fix/share-unsaved-note-content-3300

Conversation

@xhon-pelushi

Copy link
Copy Markdown

Summary

  • Share the live editor buffer via getContent() instead of the possibly stale note.getContent() from Room.
  • First share of a newly typed, not-yet-persisted note now includes the typed text.

Fixes #3300

Test plan

  • Create a new note, type text, Share once — receiving app shows the text.
  • Share again after leaving/returning — still works.
  • Sharing an already-saved note is unchanged.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sharing used the persisted note content, so a newly typed note could
produce an empty share intent until a later save refreshed Room.

Fixes nextcloud#3300

Signed-off-by: xhon-pelushi <xhon@pelushi.com>
@xhon-pelushi
xhon-pelushi force-pushed the fix/share-unsaved-note-content-3300 branch from 9653418 to fb98f89 Compare August 12, 2026 05:19
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sharing an unsaved new note exports empty content on first attempt

1 participant