fix: Tapping an item in list widget should open the tapped note - #3312
fix: Tapping an item in list widget should open the tapped note#3312nkming2 wants to merge 1 commit into
Conversation
Marking the pending intent as immutable will prevent the system to fill in the data later. It will then open an empty note as the note id is empty
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Currently when tapping an item in the list widget, the app will open an empty note instead of the tapped note. This has been reported in multiple issues like: #3168 #2790
The reason behind this is that the pending intent template is marked as immutable. This make it impossible for the system to fill in the data later. It will then open an empty note as the note id is passed to the editor as empty.
This PR added the mutable flag to the pending intent.
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)