fix(Versions): update version only after save with current mtime - #6017
Open
blizzz wants to merge 1 commit into
Open
fix(Versions): update version only after save with current mtime#6017blizzz wants to merge 1 commit into
blizzz wants to merge 1 commit into
Conversation
- files_version matches the item's mtime with the node's to consider
whether an item is the current one. This often does not match with
Date.now() as it does not match real file's mtime
- fetches the current mtime from the server upon save. This can be avoided,
when Collabora also sends the mtime along the Doc_ModifiedStatus message
- Action_Save and UI_Save actions would trigger updates before the actual
save action, meta data cannot be correct at this time
- There are still edge cases:
1. The current version is not always detected correctly, leading to
"broken" preview image and download link. The image stays until a
refresh, the link will work once it turns into a regular version.
It is already a lot better.
2. Sometimes the version generation can take longer (saw it happening
once after 2min), in those case the preview and download link do not
work. Out of scope here.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Assisted-by: Claude:claude-sonnet-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Assisted-by: Claude:claude-sonnet-5
Checklist
馃弫 Checklist
馃 AI (if applicable)