feat(users): migrate UsersDao, UsersRepository and UserManager to coroutines - #6644
Draft
mahibi wants to merge 1 commit into
Draft
feat(users): migrate UsersDao, UsersRepository and UserManager to coroutines#6644mahibi wants to merge 1 commit into
mahibi wants to merge 1 commit into
Conversation
mahibi
force-pushed
the
migrateUserManagerToCoroutines
branch
from
September 8, 2026 15:39
fb61129 to
eed482b
Compare
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/34246126796/artifacts/10064452703 |
…outines Convert the user data layer (UsersDao, UsersRepository/Impl) from RxJava2 to suspend fun/Flow, mirroring the ConversationsDao pattern already used elsewhere. UserManager gains suspend counterparts for every method alongside its existing RxJava-typed API, which is now deprecated and bridges to the suspend implementation via kotlinx-coroutines-rx2, so the ~50 existing call sites keep compiling unchanged. Follow-up PRs will migrate those callers in batches and then remove the deprecated methods. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
migrateUserManagerToCoroutines
branch
from
September 10, 2026 10:35
eed482b to
08cffb6
Compare
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/34466901916/artifacts/10150441248 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)