Repository navigation
fix(nfcore_build): update to nf-core/tools 4.1.0 and current nf-core/demo - #1008
Closed
FriederikeHanssen wants to merge 2 commits into
Closed
FriederikeHanssen wants to merge 2 commits into
FriederikeHanssen wants to merge 2 commits into
Conversation
Contributor
|
Nextflow linting complete! ❌ 1 files had 5 errors 💡 Tip: Click filename locations to go directly to that code. View all 36 issuesView formatting changes
|
This was referenced Oct 13, 2026
…and nf-core/demo - 01: show demo's local cowpy module, drop container-config log line, update samplesheetToList excerpt and linenums, add validation WARN lines to the test-profile run output - 02: update modules install output, remove NotADirectoryError note, make install step work from either starting point, show real find/concatenate input declaration - 03: use lowercase tool name for modules create, document Bioconda prompt, show real generated main.nf, drop unused args from stub - solutions: use def for ch_versions/ch_collated_versions as in the template; drop unused args from cowpy stub Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Pin nf-core==4.1.0 in the devcontainer, update the English nfcore_build and nfcore_use orientation pages and the schema-build banner in 04_input_validation, and set nf_core_version: 4.1.0 in the core-hello-part1..4 solution .nf-core.yml files. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
FriederikeHanssen
force-pushed
the
fix/nfcore-build-batch-param
branch
from
October 13, 2026 13:21
8fd4864 to
bc21722
Compare
FriederikeHanssen
force-pushed
the
fix/nfcore-build-tools-drift
branch
from
October 13, 2026 13:21
4dae36d to
3eab420
Compare
Collaborator
|
Superseded by #1012. Carried over: the demo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Hello nf-core course's documented tool output no longer matched nf-core/tools 4.1.0 or the current nf-core/demo pipeline. This PR updates the docs and solutions to match, and bumps the devcontainer pin from
nf-core==4.0.2to4.1.0in the same change. Docs and environment have to move together: on 4.0.2 the old text was correct (for example,modules installstill raisesNotADirectoryError).Stacked on #1007 (→ #1006 → #1005). Review only the 2 commits in this PR.
Changes
.devcontainer/local-features/uv-tools/install.shnf-core==4.0.2→4.1.0. Onlynf-coreis installed by this script, and it's also what theghcr.io/nextflow-io/trainingimage build uses. No CI job runs nf-core commands.nfcore_build/00_orientation.md,nfcore_use/00_orientation.mdmodules/local/cowpy. Updated the tree and replaced "there are no local modules" with a short local vs nf-core modules explanation.Generated container configs…, which 4.1.0 doesn't print without amodules/directory.samplesheetToList(input, …)at line 84 (fresh 4.1.0 template), plus a note on whereinputcomes from.WARN: Unrecognized config option 'validation.*'lines a fresh-template run printsNotADirectoryError). Removed the "ignore the error" paragraph. "Reinstalling modules…" prose no longer names a version. Dropped thecd core-hellothat failed for learners who used the start-fresh box.path(files_in, stageAs: 'to_concatenate/*', arity: '1..*'), with one sentence explaining itmodules createuses lowercasecowpy(4.1.0 warns onCOWPY). Documents the new Bioconda prompt. Generatedmain.nfblocks match the 4.1.0 template: leading blank lines, one-lineinput:, correctedlinenums/hl_lines. Removed the unuseddef argsfrom the stub (nextflow lint:Variable was declared but not used)..nf-core.ymlnf_core_version: 4.1.0.workflows/hello.nfusesdef ch_versions = …/def ch_collated_versions = …, as in the docs and the 4.1.0 template. cowpy stubargsremoved in part3/4.Testing
Run with nf-core/tools 4.1.0, Nextflow 26.04.4, the v2 parser and Docker. An independent second pass re-reproduced each claim.
pipelines create,modules install,modules create(prompts driven through a pty) and the §5.5 run all checked.main.nfreproducessolutions/core-hello-part3/modules/local/cowpy/main.nf-profile test,dockerand printPipeline completed successfully.nextflow lintshows no errors.nextflowVersionis unchanged./check-highlightsand pre-commit passNot in this PR
docs/en/docs/nfcore_build/img/nf-core_demo_code_organization.svgdoesn't show the newlocal/cowpymodule and needs a manual diagram update.solutions/core-hello-part1, which was made with 4.0.2 (extracli_typecastinput toUTILS_NFSCHEMA_PLUGIN,process_low_memorylabel). The lesson code doesn't depend on either.🤖 Generated with Claude Code