Repository navigation
chore(nfcore_build): bump nf-core/tools to 4.1.0 - #1014
Merged
FriederikeHanssen merged 3 commits intoOct 14, 2026
Merged
FriederikeHanssen merged 3 commits into
FriederikeHanssen merged 3 commits into
Conversation
Update the devcontainer pin, the required-version text in the orientation page, and the nf-core/tools banners in lesson output. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Nextflow linting complete! ❌ 1 files had 5 errors 💡 Tip: Click filename locations to go directly to that code. View all 34 issues
View formatting changes
|
…/tools 4.1.0 - Part 1 §2.1: pipelines create no longer prints the container-config line - Part 1 §5.1-5.2: input-channel block starts at line 84 in the 4.1.0 template - Part 2 §1.4: modules install no longer fails with NotADirectoryError on single-file local modules; it now prints the include statement Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Apply the 4.0.2 -> 4.1.0 template changes to core-hello-part1..4: updated utils_nfschema_plugin subworkflow (cli_typecast input, parameters_schema option keys), the extra argument passed to it from the local utils subworkflow, the process_low_memory label, new subworkflow SHAs in modules.json, and nf_core_version in .nf-core.yml. Update the docs that show these files: the modules.json SHAs in Part 2, and the utils_nfcore_hello_pipeline line numbers and the utils_nfschema_plugin error line in Part 4. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pinin4fjords
approved these changes
Oct 14, 2026
FriederikeHanssen
marked this pull request as ready for review
October 14, 2026 09:49
FriederikeHanssen
merged commit Oct 14, 2026
d47df77
into
fix/nfcore-build-training-fixes
6 checks passed
pinin4fjords
added a commit
that referenced
this pull request
Oct 14, 2026
…ing environment (#1012) * fix(nfcore_build): correct Hello nf-core materials for the training environment Fix bugs and inaccuracies in the Build with nf-core course against the training image (Nextflow 26.04.4, nf-core/tools 4.0.2), found in Friederike's walkthrough (#1005-#1011) and re-verified on 4.0.2: - Demo symlink: Nextflow 26.04 stores pulled pipelines under assets/.repos/<org>/<name>/clones/<commit>, so the old assets symlink left pipelines/nf-core/demo missing. - nf-core/demo now ships modules/local/cowpy; update the modules tree. - Line numbers, highlights and Before blocks that did not match the files produced by the 4.0.2 template and the lesson steps. - modules create: tool name must be lowercase, document the Bioconda prompt, and show the generated main.nf as 4.0.2 writes it. - find/concatenate excerpt now matches the installed module signature. - Part 4: declare batch in nextflow.config before schema build, and pass --batch in the invalid-input test so the output shows only file errors. - Solutions: part4 validate_params = true, composable-hello docker config, and FIND_CONCATENATE include order matching Part 2. Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(nfcore_build): align solutions with lesson end state and document install traceback - Solutions part1-4: workflows/hello.nf and the utils_nfcore_hello_pipeline subworkflow now match what the 4.0.2 template plus the lesson edits produce, so the "start fresh" boxes give files that match the Before blocks and line numbers. - Part 2: show the long traceback that `nf-core modules install` prints before NotADirectoryError on 4.0.2, and drop the claim that `info` writes no files (it rewrites modules.json). Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(nfcore_build): have attendees switch their scaffold to nf-schema 2.7.2 The nf-core/tools pipeline template pins nf-schema 2.5.1, which prints `WARN: Unrecognized config option 'validation.*'` on every run under Nextflow 26.04. The solutions and the Part 2-4 docs are written against 2.7.2, but nothing told attendees to switch, so their runs never matched the documented output. Part 1 §2.2 now has them update the pin, the §5.5 output shows the one-off plugin download, and the stray download line in Part 3 §1.2.4 is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(nfcore_build): clone nf-core/demo for browsing instead of symlinking the asset cache `nextflow clone` puts the default revision directly at pipelines/nf-core/demo, so the setup no longer depends on the Nextflow 26.04 per-revision clone layout. The course only reads the demo code, so the pull is not needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(nfcore_build): point Part 1 file-explorer instruction at pipelines/nf-core/demo Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(nfcore_build): bump nf-core/tools to 4.1.0 (#1014) * chore(nfcore_build): bump nf-core/tools to 4.1.0 Update the devcontainer pin, the required-version text in the orientation page, and the nf-core/tools banners in lesson output. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(nfcore_build): update command output and line numbers for nf-core/tools 4.1.0 - Part 1 §2.1: pipelines create no longer prints the container-config line - Part 1 §5.1-5.2: input-channel block starts at line 84 in the 4.1.0 template - Part 2 §1.4: modules install no longer fails with NotADirectoryError on single-file local modules; it now prints the include statement Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(nfcore_build): update solutions to the nf-core/tools 4.1.0 template Apply the 4.0.2 -> 4.1.0 template changes to core-hello-part1..4: updated utils_nfschema_plugin subworkflow (cli_typecast input, parameters_schema option keys), the extra argument passed to it from the local utils subworkflow, the process_low_memory label, new subworkflow SHAs in modules.json, and nf_core_version in .nf-core.yml. Update the docs that show these files: the modules.json SHAs in Part 2, and the utils_nfcore_hello_pipeline line numbers and the utils_nfschema_plugin error line in Part 4. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1012. This bumps nf-core/tools in the Hello nf-core course (nfcore_build) from 4.0.2 to 4.1.0.
It contains only the changes 4.1.0 requires. There are no style or wording edits. Each part was walked through with nf-core/tools 4.1.0 and Nextflow 26.04.4, and every change below was checked against this branch.
Changes
.devcontainer/local-features/uv-tools/install.sh:nf-core==4.1.000_orientation.md: the required version is now 4.1.0nf-core/tools versionbanner in command outputnf-core pipelines createno longer printsGenerated container configs for the pipeline successfully.(the template has nomodules/yet). Removed that line and the matching words in the sentence before it.utils_nfcore_hello_pipeline/main.nfstarts at line 84, not 83. Updatedlinenums. The content is unchanged.modules info"Reinstalling modules…" message now gives 4.1.0 as the version. The message still appears.nf-core modules install find/concatenateno longer fails withNotADirectoryErroron the single-filecowpy.nflocal module. It exits cleanly and prints theincludestatement. Replaced the output block and removed the paragraph about the traceback.Solutions (
nfcore-build/solutions/core-hello-part1topart4)These were 4.0.2 scaffolds. I applied the exact 4.0.2 → 4.1.0 template diff, taken from
nf-core pipelines createrun with both versions:subworkflows/nf-core/utils_nfschema_plugin/: the 4.1.0 version, with the newcli_typecastinput and theparameters_schemaoption keys.tests/nextflow.configkeeps fix(nfcore_build): correct Build with nf-core materials for the training environment #1012's nf-schema 2.7.2.subworkflows/local/utils_nfcore_hello_pipeline/main.nf: passes the extrafalseargument toUTILS_NFSCHEMA_PLUGIN.conf/base.config: the newprocess_low_memorylabel.modules.json: new SHAs forutils_nextflow_pipelineandutils_nfschema_plugin..nf-core.yml:nf_core_version: 4.1.0.docs/output.mdanddocs/usage.md: template wording.Docs that show these files:
modules.jsonblock uses the new SHAs.utils_nfcore_hello_pipeline/main.nfchange from 83 to 84.utils_nfschema_plugin/main.nf' at line: 72. It was line 68.Verification
core-hello-part1topart4all pass a fresh run and a-resumerun with-profile docker,test.cast_cli_params: false. The validation messages are otherwise unchanged.Not changed
schema buildoutput and validation errors are unchanged.modules.jsonformatting: 4.1.0 runs prettier onmodules.jsononly when the pipeline is inside a git repo. Outside one, the output matches the current block. Inside one, the arrays are written on one line with 2-space indentation. I left the block as it is because this depends on the environment.🤖 Generated with Claude Code