Repository navigation
Conversation
botocore's credential provider for console login credentials (a profile with `login_session`, from `aws login`) requires the optional awscrt dependency, which boto3's [crt] extra provides. Without it, commands that use AWS, such as `nextstrain remote` with s3:// addresses and `nextstrain build --aws-batch`, failed with a MissingDependencyException for users of such profiles. The extra doesn't constrain boto3's version, so it keeps the dependency resolution behaviour described in the existing comment. Related-to: <#533> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trvrb
marked this pull request as ready for review
October 23, 2026 22:12
victorlin
approved these changes
Oct 23, 2026
victorlin
left a comment
victorlin
left a comment
Member
There was a problem hiding this comment.
+1 for the feature; small note that docs could be updated.
Comment on lines
+22
to
+26
| * AWS console login credentials (from `aws login`) are now supported by | ||
| commands that use AWS, such as `nextstrain remote` with `s3://` addresses and | ||
| `nextstrain build --aws-batch`. Previously, these commands failed with an | ||
| error about a missing `botocore[crt]` dependency. | ||
| ([#533](https://github.com/nextstrain/cli/issues/533), [#553](https://github.com/nextstrain/cli/pull/553)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via Claude
Description of proposed changes
Depends on
boto3[crt]instead ofboto3. The extra adds awscrt, which botocore's credential provider needs for console login credentials (a profile withlogin_session, fromaws login). Without it, commands that use AWS fail with aMissingDependencyExceptionfor users of such profiles. That includesnextstrain remotewiths3://addresses andnextstrain build --aws-batch.@joverlee521 suggested this in #533, as a separate change from the fix for
nextstrain loginin #552.The extra doesn't constrain boto3's version, so the resolution concern in the existing
setup.pycomment (#496) still holds. Locally, pip resolved the same boto3, botocore and aiobotocore versions as on master, plus awscrt 0.36.0.The standalone build should bundle awscrt's compiled module in
lib/, like our other compiled modules. If it doesn't load there, the fallback is to addawscrttopkgs_requiring_fileinpyoxidizer.bzl.Conda doesn't support pip extras, so after release the Bioconda recipe will need
awscrtadded as a run dependency.Related issues
Related to #533
Checklist
./devel/pytestlocally; CI pending)nextstrain remote ls s3://…withAWS_PROFILEset to anaws loginprofile fails on master and succeeds on this branch🤖 Generated with Claude Code