You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Documentation tests with dependency version requirements are incorrectly skipped #251
The root cause are changes in pytest-doctestplus behavior introduced in 1.6.0 and not fully rectified in 1.7.0.
I will separately propose a workaround, but that workaround will be much more verbose and contain code duplication, making it worse than the original. The workaround will give us two choices:
Put the workaround in place, and keep this technical debt to put the code back the way it was after the root issue gets fixed.
Live with limited coverage until the root cause gets fixed.
@bkeryan, My apologies for delayed response. I don't believe that we have to do anything beyond upgrading the dependency.
If memory serves me correctly, we could elect to strengthen our documentation tests by making sure that the expected number of them passes to avoid scenarios like the one documented in this issue going forward. Let me know if you want me to document this idea separately and tell me how you want me to classify it.
Activity
bkeryan commentedon Jun 4, 2026
@KostaIlic2 is there anything left to do to uptake the fix from scientific-python/pytest-doctestplus#319 ?
KostaIlic2 commentedon Jun 18, 2026
@bkeryan, My apologies for delayed response. I don't believe that we have to do anything beyond upgrading the dependency.
If memory serves me correctly, we could elect to strengthen our documentation tests by making sure that the expected number of them passes to avoid scenarios like the one documented in this issue going forward. Let me know if you want me to document this idea separately and tell me how you want me to classify it.
bkeryan commentedon Jun 18, 2026
Ok.
I confirmed that https://github.com/ni/nitypes-python/actions/runs/27635964747/job/81723423655 shows that the doctests were run:
This test summary tells us when tests are removed: