fix(core): strengthen verify() invariants - #37
Merged
Merged
Conversation
verify() checked sortedness, non-overlap, and volume-sum == 1, but a leaf set that is misaligned or extends past the domain can satisfy all three (sorted, disjoint, summing to 1) while lying off-grid. Add per-leaf checks that the level is in range, the code is aligned to its level (low DIM*(max_level-lvl) bits zero), and the code is inside the domain, so the oracle the tests rely on actually rejects those states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the parallel adversarial audit (agent 1, core).
verify()checked sortedness + non-overlap + volume-sum==1, but a misaligned or out-of-domain leaf set can satisfy all three (sorted, disjoint, summing to 1) while lying off-grid — so the oracle the whole test suite trusts would accept a malformed tree. Adds per-leaf checks: level in[0, max_level], code aligned to its level (lowDIM*(max_level-lvl)bits zero), and code inside the domain. Not reachable via refine/coarsen (they preserve these), so this strengthens the test oracle rather than fixing an active bug. All 19 omp cases still pass (no false positives); clang-format + pre-commit clean.