Fix SCP confirmation and endpoint validation; enforce SFTP - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Yselecting Download after the user chose Upload.host:path, URIs, and raw Windows drive paths cannot silently become a second SSH endpoint.scp -s --; never retry with legacy SCP.Validation
bash -n Shell-scripts/scp.sh: passed.shellcheck --severity=style Shell-scripts/scp.sh: passed with ShellCheck 0.11.0.python3 -m unittest discover -s tests -v: all 24 tests passed locally.git diff --check: passed.-srequests the SFTP subsystem, using a fake SSH program that never connects.Compatibility and scope
/; use/mnt/c/...for Windows files in WSL.C:/Users/me/file.txt.This pull request targets
mainbut does not merge or modify that branch.