Repository navigation
Move lemon's MySQL from 8.4 to 9.7, the current LTS - #19
Merged
Merged
Conversation
The mysql image's lts tag now points at 9.7; 8.4 is the previous LTS line, still supported, so this is an upgrade rather than a fix. Only the compose image and the README's description of run.sh name the version. A fresh volume, which is every CI run, starts 9.7.4 and the suite passes 16 of 16 in 3 of 3 runs; the TCP healthcheck still holds `--wait` until the image's temporary init server has stopped. An existing volume upgrades in place on its first start under 9.7: the volume this was tested on, initialised by 8.4.13, logged its data dictionary upgrading from 80300 to 90200 and the server from 80413 to 90704 with no errors, kept its lemon database, and passed the suite. MySQL cannot downgrade such a volume, so compose.yaml says so beside the image. `make check` passes in all four projects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PJbZcrXFYA1x2ppHdCG5uT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lemon's database moves from
mysql:8.4tomysql:9.7. The image'sltstag now points at 9.7, while 8.4 is the previous LTS line: still supported, so this is an upgrade rather than a fix.Only two places name the version: the image in
lemon/compose.yamland the README's description ofrun.sh. A comment next to the image notes that an existing volume upgrades in place and can't be downgraded afterwards.What developers will see
The first time
makeorrun.shstarts MySQL on an existing local volume, the server upgrades the data in place. That takes a few seconds, and nothing needs doing. After that, the volume can't go back to 8.4. To start clean instead, runmake -C lemon db-reset.Test plan
--waituntil the image's temporary setup server has stopped.Data dictionary upgrading from version '80300' to '90200'andServer upgrade from '80413' to '90704' completed, with no errors.lemondatabase, and the suite passes on it.make checkfrom the repository root passes in all four projects (141 tests).Generated by Claude Code